Skip to content
/ rector-src Public

[DX] Make configurable include post rector classes in result#7372

Closed
samsonasik wants to merge 1 commit intomainfrom
make-configurable-report
Closed

[DX] Make configurable include post rector classes in result#7372
samsonasik wants to merge 1 commit intomainfrom
make-configurable-report

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 29, 2025 •
edited
Loading

@TomasVotruba per discussion on #7365 (comment)

This is make configurable in case you want to consider it, this is default to false so user needs to enable it in the config, via:

$rectorConfig->includePostRectorsInReports(true);

or

return RectorConfig::configure()
      // ...
     ->withIncludePostRectorsInReports(true);

/cc @simonschaufi

@samsonasik samsonasik mentioned this pull request Sep 29, 2025
Merged
@samsonasik
Copy link
Member Author

samsonasik commented Sep 29, 2025

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

TomasVotruba commented Sep 29, 2025

As I wrote, I want to keep post Rectors as internal separated feature and keep configuration to minimum to make it readable. Adding off/on option here and there would turn into choice paralysis mess.

@simonschaufi
Copy link
Contributor

simonschaufi commented Sep 29, 2025 •
edited
Loading

😢 I'm sad about this decision. Post rectors still change code and are not just an internal rector thing

@TomasVotruba TomasVotruba deleted the make-configurable-report branch September 29, 2025 21:05
@rectorphp rectorphp locked as resolved and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba @simonschaufi